chore: add api endpoints to get idp field values #16063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Jan 8, 2025
codersdk/idpsync.go
Outdated
| @@ -163,3 +163,31 @@ func (c *Client) GetOrganizationAvailableIDPSyncFields(ctx context.Context, orgI | |||
| var resp []string | |||
| return resp, json.NewDecoder(res.Body).Decode(&resp) | |||
| } | |||
|
|
|||
| func (c *Client) GetIDPSyncFieldValues(ctx context.Context, claimField string) ([]string, error) { | |||
| res, err := c.Request(ctx, http.MethodGet, fmt.Sprintf("/api/v2/settings/idpsync/field-values?claimField=%s", claimField), nil) | |||
There was a problem hiding this comment.
claimField=%s will not url encode special characters.
Suggested change
| res, err := c.Request(ctx, http.MethodGet, fmt.Sprintf("/api/v2/settings/idpsync/field-values?claimField=%s", claimField), nil) | |
| qv := url.Values{} | |
| qv.Add("claimField", claimField) | |
| res, err := c.Request(ctx, http.MethodGet, fmt.Sprintf("/api/v2/settings/idpsync/field-values?%s", qv.Encode()), nil) |
Example: https://go.dev/play/p/zN-CJsgWkz0
enterprise/coderd/idpsync.go
Outdated
Comment on lines
398
to
400
| ctx := r.Context() | ||
|
|
||
| fields, err := api.Database.OIDCClaimFieldValues(ctx, database.OIDCClaimFieldValuesParams{ |
There was a problem hiding this comment.
just do the claimField parsing in here.
Suggested change
| ctx := r.Context() | |
| fields, err := api.Database.OIDCClaimFieldValues(ctx, database.OIDCClaimFieldValuesParams{ | |
| ctx := r.Context() | |
| claimField := r.URL.Query().Get("claimField") | |
| fields, err := api.Database.OIDCClaimFieldValues(ctx, database.OIDCClaimFieldValuesParams{ |
Also you should defend against an empty string here.
if claimField == "" {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: "claimField query parameter is required",
})
return
}
Emyrk
approved these changes
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports coder/internal#210