feat: add coder logout command #1609
Conversation
|
Closes #1606 |
| Short: "Remove local autheticated session", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| config := createConfig(cmd) | ||
| err := os.RemoveAll(string(config)) |
There was a problem hiding this comment.
Maybe I'm just paranoid, but I think this should only remove config.Session(), config.URL() and config.Organization(), and not any other files that happen to have ended up in the directory (at least not without confirmation). I would be worried that a misconfigured CODER_CONFIG_DIR could lead to somebody accidentally wiping out their home directory.
See e.g. ValveSoftware/steam-for-linux#3671
There was a problem hiding this comment.
I totally agree, we shouldn't delete the folder. I wouldn't put it past that some users are storing a url.bak or session.bak. Or any other related material really that they've cooked up themselves.
| func logout() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "logout", | ||
| Short: "Remove local autheticated session", |
There was a problem hiding this comment.
typo: s/autheticated/authenticated/
A
coder logoutcommand is useful so users do not have to find and delete the session files manually.