feat: use wildcard Host entry in config-ssh #16096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
commented
Jan 11, 2025
aaronlehmann
commented
Jan 11, 2025
| }, | ||
| matches: []match{ | ||
| {match: "Continue?", write: "yes"}, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Section is not moved on re-run", |
There was a problem hiding this comment.
This test case (and also No prompt on no changes below) is a bit tricky to support because it requires writing out a file that will exactly match what we generate. I can rework the test to make this possible if needed, though.
There was a problem hiding this comment.
Hmm, I think I'm fine losing these for now and I'll make a note to come back to it 😎
Rather than create a separate Host entry for every workspace, configure a wildcard such as `coder.*` which can accomodate all of a user's workspaces.
ceab646 to
3437757
Compare
bcpeinhardt
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than create a separate
Hostentry for every workspace, configure a wildcard such ascoder.*which can accomodate all of a user's workspaces.Depends on #16088.