feat: enable editing of IDP sync configuration for groups and roles in the UI #16098
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| import { expect, test } from "@playwright/test"; | ||
| import { | ||
| createGroupSyncSettings, | ||
| createOrganizationWithName, | ||
| deleteOrganization, | ||
| setupApiCalls, | ||
| } from "../../api"; | ||
| import { randomName, requiresLicense } from "../../helpers"; | ||
| import { login } from "../../helpers"; | ||
| import { beforeCoderTest } from "../../hooks"; | ||
|
|
||
| test.beforeEach(async ({ page }) => { | ||
| beforeCoderTest(page); | ||
| await login(page); | ||
| await setupApiCalls(page); | ||
| }); | ||
|
|
||
| test.describe("IdpGroupSyncPage", () => { | ||
| test("show empty table when no group mappings are present", async ({ | ||
| page, | ||
| }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| await expect( | ||
| page.getByRole("row", { name: "idp-group-1" }), | ||
| ).not.toBeVisible(); | ||
| await expect( | ||
| page.getByRole("heading", { name: "No group mappings" }), | ||
| ).toBeVisible(); | ||
|
|
||
| await deleteOrganization(org.name); | ||
|
There was a problem hiding this comment. I'm asking because I haven't had much chance to touch Playwright yet, and don't know what it does for test setup: is I'm mainly wondering why the call is present for the first two tests as (what looks like) a cleanup step, but some of the later, non-deletion tests in this file don't have it There was a problem hiding this comment. I'm also not sure if Playwright supports any "true concurrency", rather than doing everything through the event loop There was a problem hiding this comment. I originally added this to fix some test failures across tests that were creating organizations. From the documentation and my testing, it does appear tests are run in parallel. The intention was to add this cleanup step anytime an org is created to avoid test flakes in the future. |
||
| }); | ||
|
|
||
| test("add new IdP group mapping with API", async ({ page }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await createGroupSyncSettings(org.id); | ||
|
|
||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| await expect( | ||
| page.getByRole("switch", { name: "Auto create missing groups" }), | ||
| ).toBeChecked(); | ||
|
|
||
| await expect(page.getByRole("row", { name: "idp-group-1" })).toBeVisible(); | ||
| await expect( | ||
| page.getByRole("row", { name: "fbd2116a-8961-4954-87ae-e4575bd29ce0" }), | ||
| ).toBeVisible(); | ||
|
|
||
| await expect(page.getByRole("row", { name: "idp-group-2" })).toBeVisible(); | ||
| await expect( | ||
| page.getByRole("row", { name: "6b39f0f1-6ad8-4981-b2fc-d52aef53ff1b" }), | ||
| ).toBeVisible(); | ||
|
|
||
| await deleteOrganization(org.name); | ||
| }); | ||
|
|
||
| test("delete a IdP group to coder group mapping row", async ({ page }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await createGroupSyncSettings(org.id); | ||
|
|
||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| const row = page.getByTestId("group-idp-group-1"); | ||
| await expect(row.getByRole("cell", { name: "idp-group-1" })).toBeVisible(); | ||
| await row.getByRole("button", { name: /delete/i }).click(); | ||
| await expect( | ||
| row.getByRole("cell", { name: "idp-group-1" }), | ||
| ).not.toBeVisible(); | ||
| await expect( | ||
| page.getByText("IdP Group sync settings updated."), | ||
| ).toBeVisible(); | ||
| }); | ||
|
|
||
| test("update sync field", async ({ page }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| const syncField = page.getByRole("textbox", { | ||
| name: "Group sync field", | ||
| }); | ||
| const saveButton = page.getByRole("button", { name: /save/i }); | ||
|
|
||
| await expect(saveButton).toBeDisabled(); | ||
|
|
||
| await syncField.fill("test-field"); | ||
| await expect(saveButton).toBeEnabled(); | ||
|
|
||
| await page.getByRole("button", { name: /save/i }).click(); | ||
|
|
||
| await expect( | ||
| page.getByText("IdP Group sync settings updated."), | ||
| ).toBeVisible(); | ||
| }); | ||
|
|
||
| test("toggle off auto create missing groups", async ({ page }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| const toggle = page.getByRole("switch", { | ||
| name: "Auto create missing groups", | ||
| }); | ||
| await toggle.click(); | ||
|
|
||
| await expect( | ||
| page.getByText("IdP Group sync settings updated."), | ||
| ).toBeVisible(); | ||
|
|
||
| await expect(toggle).toBeChecked(); | ||
| }); | ||
|
|
||
| test("export policy button is enabled when sync settings are present", async ({ | ||
| page, | ||
| }) => { | ||
| requiresLicense(); | ||
| const org = await createOrganizationWithName(randomName()); | ||
| await createGroupSyncSettings(org.id); | ||
| await page.goto(`/organizations/${org.name}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| const exportButton = page.getByRole("button", { name: /Export Policy/i }); | ||
| await expect(exportButton).toBeEnabled(); | ||
| await exportButton.click(); | ||
| }); | ||
|
|
||
| test("add new IdP group mapping with UI", async ({ page }) => { | ||
| requiresLicense(); | ||
| const orgName = randomName(); | ||
| await createOrganizationWithName(orgName); | ||
|
|
||
| await page.goto(`/organizations/${orgName}/idp-sync?tab=groups`, { | ||
| waitUntil: "domcontentloaded", | ||
| }); | ||
|
|
||
| const idpOrgInput = page.getByLabel("IdP group name"); | ||
| const orgSelector = page.getByPlaceholder("Select group"); | ||
| const addButton = page.getByRole("button", { | ||
| name: /Add IdP group/i, | ||
| }); | ||
|
|
||
| await expect(addButton).toBeDisabled(); | ||
|
|
||
| await idpOrgInput.fill("new-idp-group"); | ||
|
|
||
| // Select Coder organization from combobox | ||
| await orgSelector.click(); | ||
| await page.getByRole("option", { name: /Everyone/i }).click(); | ||
|
|
||
| // Add button should now be enabled | ||
| await expect(addButton).toBeEnabled(); | ||
|
|
||
| await addButton.click(); | ||
|
|
||
| // Verify new mapping appears in table | ||
| const newRow = page.getByTestId("group-new-idp-group"); | ||
| await expect(newRow).toBeVisible(); | ||
| await expect( | ||
| newRow.getByRole("cell", { name: "new-idp-group" }), | ||
| ).toBeVisible(); | ||
| await expect(newRow.getByRole("cell", { name: "Everyone" })).toBeVisible(); | ||
|
|
||
| await expect( | ||
| page.getByText("IdP Group sync settings updated."), | ||
| ).toBeVisible(); | ||
|
|
||
| await deleteOrganization(orgName); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a test ID selector here? I'm not sure why the row selectors wouldn't work here, but would still work for other test cases