Skip to content

chore: predicate slack notification job on other jobs #16106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: predicate slack notification job on other jobs #16106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/nightly-gauntlet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,11 @@ jobs:
api-key: ${{ secrets.DATADOG_API_KEY }}

notify-slack-on-failure:
needs:
- go-race
- go-timing
runs-on: ubuntu-latest
if: always() && failure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always() && failure() is the same as failure(). I think the operative part here is the needs section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned the operative part in the title, although agree this could've been more explicit.

Clause Sonnet suggested that always() could be used if you wanted to handle all jobs (i.e. not have to exhaustively define needs), but maybe that's wrong.

I hate GHA.

if: failure()

steps:
- name: Send Slack notification
Expand Down
Loading