chore: only notify about CI failure on main if required job fails
#16114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
matifali
approved these changes
Jan 13, 2025
|
coder/.github/workflows/ci.yaml Line 1283 in e53b675 From your earlier screenshot, I believe this will always be notify-slack-on-failure. Idk how easy fixing it is - can probably just remove for now, the notif that something has failed should be good enough!
|
Haha I just noticed that now too. Looking into it. |
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last PR to get this working
Looks like the
nightly-gauntletis working as expected, and this is a clone of that.@ethanndickson @matifali sorry fellas, last review from me I'm hoping