chore: add Select component #16121
Merged
chore: add Select component #16121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
reviewed
Jan 13, 2025
| <SelectPrimitive.Content | ||
| ref={ref} | ||
| className={cn( | ||
| "relative z-50 max-h-96 min-w-[8rem] overflow-hidden rounded-md border border-border border-solid bg-surface-primary text-content-primary shadow-md data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2", |
There was a problem hiding this comment.
For long Tailwind class names, I have been following the pattern of using multi-line strings to make these easier to read. See some of the other existing shadcn components.
jaaydenh
reviewed
Jan 13, 2025
| )); | ||
| SelectSeparator.displayName = SelectPrimitive.Separator.displayName; | ||
|
|
||
| export { |
There was a problem hiding this comment.
So far I have been exporting in place instead of the bottom of the file for the shadcn components as this matches the current patterns in the codebase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15297 and based on this design.