fix: filter unique script timings per build #16123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timings endpoint is incorrectly returning multiple script timings instead of a single one. This commit implements a workaround to address the issue on the FE side.
|
Even with this workaround in place, users may still experience memory leaks until #16124 is resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timings endpoint is incorrectly returning multiple script timings instead of a single one. This commit implements a workaround to address the issue on the FE side.
Partially addresses #15921 by identifying that the provisioner timings contain outdated dates, resulting in an excessively long time window. This causes the chart to attempt rendering thousands of ticks, consuming significant memory.