feat: open app in tab or slim-window #16152
Conversation
| ); | ||
| return; | ||
| } | ||
| case "tab": { |
There was a problem hiding this comment.
Should this be the default case or are we guaranteed open_in will always be set and only contain one of these two values?
There was a problem hiding this comment.
We ensure it will always be set and contain one of these two values.
| if (app.external && !app.url.startsWith("http")) { | ||
| // If the protocol is external the browser does not | ||
| // redirect the user from the page. | ||
| const isBrowserProtocol = app.external && !app.url.startsWith("http"); |
There was a problem hiding this comment.
Oh wait this is actually the opposite, right? Not a browser protocol (like vscode://). Maybe isExternalProtocol?
Well, I guess the browser does handle it by launching the external app, but isBrowser makes me think of http://
There was a problem hiding this comment.
It made sense to me before you brought this up—now I’m not so sure. Maybe shouldOpenAppExternally?
There was a problem hiding this comment.
LGTM - Just agree with @code-asher comment on the naming for isBrowserProtocol which seems to be the opposite but as the logic itself seems good i'll not block here.
Close coder/terraform-provider-coder#297