Skip to content

chore: improve CI reliability #16169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 20, 2025
Merged

chore: improve CI reliability #16169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
53479bd
Reducing the number of iterations of go-race to make it more likely t…
dannykopping Jan 17, 2025
9e4352a
Run at 4AM to avoid possible collision with other midnight operations
dannykopping Jan 17, 2025
eb44197
Remove low-signal tests, add pg tests for windows/mac
dannykopping Jan 17, 2025
c4de10e
Run CLI tests for Windows/MacOS on each PR
dannykopping Jan 17, 2025
e6761e6
Do not run full test-suite with Postgres on Windows/MacOS on each PR
dannykopping Jan 17, 2025
f1b54b9
Testing complete
dannykopping Jan 17, 2025
43eae7e
Only run on weekdays
dannykopping Jan 17, 2025
1442d50
Fix comment location
dannykopping Jan 17, 2025
57a798c
Merge branch 'dk/ci-reliability' of github.com:/coder/coder into dk/c…
dannykopping Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Testing complete 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Jan 17, 2025
commit f1b54b92270dc63d181f764f7f85cd87a32c70fa
7 changes: 1 addition & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,12 +383,7 @@ jobs:
test-cli:
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'windows-latest-16-cores' || matrix.os }}
needs: changes


#TODO: reenable condition


#if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
strategy:
matrix:
os:
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/nightly-gauntlet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,7 @@ permissions:
jobs:
test-go-pg:
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'windows-latest-16-cores' || matrix.os }}


# TODO: re-enable main check!





# if: github.ref == 'refs/heads/main'
if: github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
# goroutines. Setting this to the timeout +5m should work quite well
Expand Down
Loading