test(Makefile): retry pulling postgres in test-postgres-docker #16178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4814457 to
196d2af
Compare
johnstcn
approved these changes
Jan 17, 2025
Makefile
Outdated
Comment on lines
868
to
871
| # Try pulling up to three times to avoid CI flakes. | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \ | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \ | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} |
There was a problem hiding this comment.
That'd work, but maybe we could add a utility script that doe something like this:
# Try pulling up to three times to avoid CI flakes.
for attempt in {1..3}; do
if [ ! docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} ]; then
echo "Failed to pull image, retrying...";
sleep 1;
else
break;
fi
done
There was a problem hiding this comment.
Ok, that'd be nicer for sure, I was just lazy. I adapted it a bit to make sure we don't print retrying after we don't retry any more 👍🏻
d57941d to
220a38a
Compare
johnstcn
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/coder/coder/actions/runs/12796458261/job/35676174099