feat(provisioner/terraform/tfparse): add support for built-in Terraform functions #16183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Jan 19, 2025
dannykopping
approved these changes
Jan 20, 2025
dannykopping
approved these changes
Jan 20, 2025
| // We cannot support all available functions here, as the result of reading a file will be different | ||
| // depending on the execution environment. | ||
| safeFunctions = map[string]function.Function{ | ||
| "abs": stdlib.AbsoluteFunc, |
There was a problem hiding this comment.
Post-merge thought: how do we align Terraform versions?
There was a problem hiding this comment.
From what I could tell it doesn't look like these functions change all that often.
However, f Terraform adds a new function in future, we'll need to add support for it ourselves. Then again, so will aquasec/trivy-iac. This is an unfortunate consequence of Terraform having made the bulk of their internal functions un-importable.
There was a problem hiding this comment.
Cool, I think we're fine here and we can just update the lib.
My only concern is if they change the semantics of the functions between versions, but I doubt they'd do that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #15977
Adds support for some functions in
tfparse(only functions that do not reference local files).NOTE: for now, I'm importing trivy-iac. If we prefer to avoid a little dependency, I can do a little copying instead.