Skip to content

fix: add groups to deployment settings #16185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2025
Merged

fix: add groups to deployment settings #16185

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f57db
fix: add groups to deployment settings
jaaydenh Jan 17, 2025
ca7862d
fix: e2e test
jaaydenh Jan 18, 2025
4a78368
fix: format
jaaydenh Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: e2e test
  • Loading branch information
@jaaydenh
jaaydenh committed Jan 18, 2025
commit ca7862ded0df02cd49b954036ac4455fc37f7a2e
6 changes: 3 additions & 3 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,13 +293,13 @@ export const createTemplate = async (
* random name.
*/
export const createGroup = async (page: Page): Promise<string> => {
await page.goto("/groups/create", { waitUntil: "domcontentloaded" });
await expectUrl(page).toHavePathName("/groups/create");
await page.goto("/deployment/groups/create", { waitUntil: "domcontentloaded" });
await expectUrl(page).toHavePathName("/deployment/groups/create");

const name = randomName();
await page.getByLabel("Name", { exact: true }).fill(name);
await page.getByRole("button", { name: /save/i }).click();
await expectUrl(page).toHavePathName(`/groups/${name}`);
await expectUrl(page).toHavePathName(`/deployment/groups/${name}`);
return name;
};

Expand Down
Loading