Obligatory reminder to double-check migration number before merging!

Something to consider...

CREATE TYPE workspace_agent_resource_monitor AS ENUM ('memory', 'volume');

CREATE TABLE workspace_agent_resource_monitors (
  id uuid not null primary key,
  agent_id uuid not null foreign key ...,
  type workspace_agent_resource_monitor not null,
  enabled bool not null,
  threshold integer not null,
  path text not null,
  created_at ...
)

This would obviously be less ideal if we plan to add other attributes later.

Not authorizing memberMe?

I am not really sure how to configure RBAC for my needs - I'll let the PR opened until I have enough in the agent one so I can validate RBAC are well configured if good for you.

I think we will need memberMe and orgMemberMe here, although it will become apparent once we add an API endpoint or similar that tries to read this data.

Adding or extending some existing tests should make it apparent what we need here.

Hhmm, I don't think this will work? The primary key needs to be unique.

https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-PRIMARY-KEYS

A primary key constraint indicates that a column, or group of columns, can be used as a unique identifier for rows in the table.

In general, when you're creating database migrations, it's good practice to perform a few basic operations against them to validate that your design works.

I see what you're trying to do, but I think you're try to be overly efficient.

Can you explain to me how we can have duplicates here ? I maybe am missing some logic.

As we authorize only one resource monitor of type memory here - and the resource monitor is linked to an agent id - I feel like it is doing what we want ?

If this one breaks it means that there is multiple memory resource monitors declared in the terraform configuration.

Hhmm, fair point. It's true that each agent should only have one memory resource monitor.

Please leave a comment in the migration explaining this constraint for future readers without context 👍
I should not review PRs before bed 🫤