Skip to content

fix(cli): remove loading indicator when pinging with verbose logs #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(cli): remove loading indicator when pinging with verbose logs #16305

merged 1 commit into from
Jan 28, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jan 28, 2025 •
edited
Loading

This was causing some verbose log lines to be prepended with the spinner message, e.g.

◱ Collecting diagnostics...2025-01-28 10:26:27.502

which doesnt look very good. Presumably anyone running it with verbose will know it takes a moment to collect diagnostics first.

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson added the hotfix PRs only. Harmless small change. Only humans may set this. label Jan 28, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Jan 28, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson marked this pull request as ready for review January 28, 2025 10:28
@ethanndickson ethanndickson enabled auto-merge (squash) January 28, 2025 10:29
@ethanndickson ethanndickson merged commit bb69054 into main Jan 28, 2025
50 checks passed
@ethanndickson ethanndickson deleted the ethan/verbose-ping-spinner branch January 28, 2025 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ethanndickson ethanndickson

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanndickson