chore: get TUN/DNS working on Windows for CoderVPN #16310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks some of the vpn.Tunnel code so it better suits the way TUN, the Router and the DNSConfigurator are instantiated on Windows.
deansheather
commented
Jan 28, 2025
| return time.Duration(int64(r)) * time.Millisecond | ||
| } | ||
|
|
||
| // TODO(@dean): implement a way to install/uninstall the wintun driver, most |
There was a problem hiding this comment.
ethanndickson
approved these changes
Jan 29, 2025
vpn/tunnel.go
Outdated
Comment on lines
236
to
238
| if t.networkingStackFn == nil { | ||
| return xerrors.New("dev error: missing networking stack function") | ||
| } |
There was a problem hiding this comment.
networkingStackFn needs to be set on Linux in the tunnel_internal_tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks some of the vpn.Tunnel code so it better suits the way TUN, the Router and the DNSConfigurator are instantiated on Windows.