Skip to content

feat: add default autostart and ttl for new workspaces #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 23, 2022
Merged

feat: add default autostart and ttl for new workspaces #1632

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c092be
Dockerfile: add tzdata
johnstcn May 20, 2022
391f527
database: add autostart_schedule and ttl to InsertWorkspace; make gen
johnstcn May 20, 2022
98561bf
coderd: workspaces: consume additional fields of CreateWorkspaceRequest
johnstcn May 20, 2022
0169315
fixup! coderd: workspaces: consume additional fields of CreateWorkspa…
johnstcn May 20, 2022
dea541f
fixup! fixup! coderd: workspaces: consume additional fields of Create…
johnstcn May 20, 2022
d621272
autobuild: fix unit tests
johnstcn May 20, 2022
2f7b939
cli: update: add support for TTL and autostart_schedule
johnstcn May 20, 2022
813a64f
cli: create: add unit tests
johnstcn May 20, 2022
1fbc0f2
lint
johnstcn May 20, 2022
142ad37
coder: use embedded tzdata instead
johnstcn May 20, 2022
0f348cd
autobuild: fix unit test that only runs with a real db
johnstcn May 20, 2022
32a86f1
address PR comments
johnstcn May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! coderd: workspaces: consume additional fields of Create… 
…WorkspaceRequest
  • Loading branch information
@johnstcn
johnstcn committed May 20, 2022
commit dea541f11a81b974a469f522f58b04a7b7e9b1cc
22 changes: 17 additions & 5 deletions coderd/coderdtest/coderdtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,11 +389,19 @@ func AwaitWorkspaceAgents(t *testing.T, client *codersdk.Client, build uuid.UUID

// CreateWorkspace creates a workspace for the user and template provided.
// A random name is generated for it.
func CreateWorkspace(t *testing.T, client *codersdk.Client, organization uuid.UUID, templateID uuid.UUID) codersdk.Workspace {
workspace, err := client.CreateWorkspace(context.Background(), organization, codersdk.CreateWorkspaceRequest{
TemplateID: templateID,
Name: randomUsername(),
})
// To customize the defaults, pass a mutator func.
func CreateWorkspace(t *testing.T, client *codersdk.Client, organization uuid.UUID, templateID uuid.UUID, mutators ...func(*codersdk.CreateWorkspaceRequest)) codersdk.Workspace {
t.Helper()
req := codersdk.CreateWorkspaceRequest{
TemplateID: templateID,
Name: randomUsername(),
AutostartSchedule: ptr("CRON_TZ=US/Central * * * * *"),
TTL: ptr(8 * time.Hour),
}
for _, mutator := range mutators {
mutator(&req)
}
workspace, err := client.CreateWorkspace(context.Background(), organization, req)
require.NoError(t, err)
return workspace
}
Expand Down Expand Up @@ -590,3 +598,7 @@ type roundTripper func(req *http.Request) (*http.Response, error)
func (r roundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
return r(req)
}

func ptr[T any](x T) *T {
return &x
}