Skip to content

fix(flake.nix): include dev buildInputs in dogfood nix image #16325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(flake.nix): include dev buildInputs in dogfood nix image #16325

merged 1 commit into from
Jan 30, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Jan 29, 2025 •
edited
Loading

Improve Nix shell environment in Dogfood Docker image

  • Pinned gcc to gcc13 in devShell
  • Add busybox, coreutils, curl, glibc, and binutils to dogfood nix image
  • Configure proper home directory and user settings in dogfood nix image
  • Set up dynamic library paths and system directories for binaries downloaded at runtime
  • Add glibc linker support for aarch64 and x86_64
  • Enable nix flakes by default in dogfood nix image
  • Optimize environment variable handling in devShell

Change-Id: I82259a2c620b1711440e79c58bbc06080d888c9a
Signed-off-by: Thomas Kosiewski tk@coder.com

@ThomasK33 Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 marked this pull request as ready for review January 29, 2025 13:30
@ThomasK33 ThomasK33 force-pushed the 01-29-fix_flake.nix_link_rcfile_to_bashrc_for_login_and_non-login_shells branch 3 times, most recently from 42d5279 to cad0b17 Compare January 30, 2025 16:28
@ThomasK33 ThomasK33 changed the title fix(flake.nix): link rcfile to bashrc for login and non-login shells fix(flake.nix): include dev buildInputs in dogfood nix image Jan 30, 2025
@ThomasK33
fix(flake.nix): link rcfile to bashrc for login and non-login shells
8009cd2 
Change-Id: I82259a2c620b1711440e79c58bbc06080d888c9a
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the 01-29-fix_flake.nix_link_rcfile_to_bashrc_for_login_and_non-login_shells branch from cad0b17 to 8009cd2 Compare January 30, 2025 16:37
@ThomasK33 ThomasK33 merged commit 6e2dc6f into main Jan 30, 2025
35 checks passed
@ThomasK33 ThomasK33 deleted the 01-29-fix_flake.nix_link_rcfile_to_bashrc_for_login_and_non-login_shells branch January 30, 2025 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@ThomasK33 ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasK33 @matifali