Skip to content

chore: track the first time html is served in telemetry #16334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 31, 2025
Merged

chore: track the first time html is served in telemetry #16334

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
63246e8
track the first time html is served in telemetry
hugodutka Jan 29, 2025
32876a2
add the telemetry_items table
hugodutka Jan 30, 2025
f68a163
add the GetTelemetryItems query
hugodutka Jan 30, 2025
6554aa3
change TelemetryItem's key to PK
hugodutka Jan 30, 2025
0a95dcd
report html first served at with a TelemetryItem
hugodutka Jan 30, 2025
5118aeb
remove ReportDeployment from Reporter
hugodutka Jan 30, 2025
a6a984f
remove GetHTMLFirstServedAt and SetHTMLFirstServedAt
hugodutka Jan 30, 2025
3f6615b
remove htmlFirstServedAt from dbmem
hugodutka Jan 30, 2025
e338c8f
revert change to siteconfig.sql
hugodutka Jan 30, 2025
0828c1d
fix tests
hugodutka Jan 30, 2025
35e79bc
add a test for reporting html first served
hugodutka Jan 30, 2025
89c8371
make the snapshot check more robust
hugodutka Jan 30, 2025
ff86e66
add telemetry_items fixture
hugodutka Jan 30, 2025
d2ca62d
Simplify telemetry item reporting context handling
hugodutka Jan 30, 2025
00c27c5
address the PR review
hugodutka Jan 31, 2025
e297740
fix typo
hugodutka Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test for reporting html first served
  • Loading branch information
@hugodutka
hugodutka committed Jan 30, 2025
commit 35e79bcb571d68123c6b5fdb76e90c7daaa8b74f
22 changes: 21 additions & 1 deletion cli/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ func TestServer(t *testing.T) {
server := httptest.NewServer(r)
defer server.Close()

inv, _ := clitest.New(t,
inv, cfg := clitest.New(t,
"server",
"--in-memory",
"--http-address", ":0",
Expand All @@ -977,6 +977,26 @@ func TestServer(t *testing.T) {

<-deployment
<-snapshot

accessURL := waitAccessURL(t, cfg)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium)
ctx := testutil.Context(t, testutil.WaitMedium)

defer cancel()
client := codersdk.New(accessURL)
body, err := client.Request(ctx, http.MethodGet, "/", nil)
require.NoError(t, err)
require.NoError(t, body.Body.Close())

snap := <-snapshot
require.Condition(t, func() bool {
htmlFirstServedFound := false
for _, item := range snap.TelemetryItems {
if item.Key == string(telemetry.TelemetryItemKeyHTMLFirstServedAt) {
htmlFirstServedFound = true
}
}
return htmlFirstServedFound
}, "no html_first_served telemetry item")
})
t.Run("Prometheus", func(t *testing.T) {
t.Parallel()
Expand Down
Loading