Skip to content

feat: orgs IDP sync - add combobox to select claim field value when sync field is set #16335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2025
Merged

feat: orgs IDP sync - add combobox to select claim field value when sync field is set #16335

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e5d88c8
feat: add dropdown to select claim field value when sync field is set
jaaydenh Jan 29, 2025
47bf431
fix: update command styles
jaaydenh Feb 3, 2025
0df2ddc
fix: replace dropdown with combobox
jaaydenh Feb 3, 2025
a11762e
chore: use shadcn table
jaaydenh Feb 4, 2025
e61b2dc
fix: set claim field when retrieving sync settings
jaaydenh Feb 4, 2025
324f594
chore: extract combobox component
jaaydenh Feb 4, 2025
1f1086d
chore: PR comments
jaaydenh Feb 4, 2025
2d98f7e
fix: update test
jaaydenh Feb 4, 2025
cff6e01
fix: format
jaaydenh Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: format
  • Loading branch information
@jaaydenh
jaaydenh committed Feb 5, 2025
commit cff6e0188c15594fa088fc813a0eb721c63ec1ac
4 changes: 1 addition & 3 deletions site/e2e/tests/deployment/idpOrgSync.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ test.describe("IdpOrgSyncPage", () => {
// Verify new mapping appears in table
const newRow = page.getByTestId(`idp-org-${idpOrgName}`);
await expect(newRow).toBeVisible();
await expect(
newRow.getByRole("cell", { name: idpOrgName }),
).toBeVisible();
await expect(newRow.getByRole("cell", { name: idpOrgName })).toBeVisible();
await expect(newRow.getByRole("cell", { name: orgName })).toBeVisible();

await expect(
Expand Down
Loading