Skip to content

chore: add 'email' field to notifications #16336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2025
Merged

chore: add 'email' field to notifications #16336

merged 4 commits into from
Jan 30, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Jan 29, 2025 •
edited
Loading

Closes coder/internal#323

This PR adds an email field to the data.owner payload for workspace created and workspace manually updated notifications.

mtojek
mtojek approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with other data fields hence 👍 from me.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review January 30, 2025 12:52
mtojek
mtojek approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff reviewed 👍

dannykopping
dannykopping reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I think it could use some hardening.

@DanielleMaywood DanielleMaywood merged commit f651ab9 into main Jan 30, 2025
36 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-add-owner-email-to-webhook-data branch January 30, 2025 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping left review comments

@mtojek mtojek mtojek approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "email" property to webhook payload
3 participants
@DanielleMaywood @dannykopping @mtojek