Skip to content

feat: form for editing ws schedule #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2022
Merged

feat: form for editing ws schedule #1634

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adeb0ff
feat: ui for editing ws schedule
greyscaled May 20, 2022
2ee8d87
validation
greyscaled May 20, 2022
a651f0e
fixup! validation
greyscaled May 20, 2022
e0a35ca
Fix helperText
greyscaled May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! validation
  • Loading branch information
@greyscaled
greyscaled committed May 20, 2022
commit a651f0e774f08676e8f9c2cdbb9defe87a08b09c
8 changes: 5 additions & 3 deletions site/src/components/WorkspaceStats/WorkspaceScheduleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Checkbox from "@material-ui/core/Checkbox"
import FormControl from "@material-ui/core/FormControl"
import FormControlLabel from "@material-ui/core/FormControlLabel"
import FormGroup from "@material-ui/core/FormGroup"
import FormHelperText from "@material-ui/core/FormHelperText"
import FormLabel from "@material-ui/core/FormLabel"
import makeStyles from "@material-ui/core/styles/makeStyles"
import TextField from "@material-ui/core/TextField"
Expand Down Expand Up @@ -88,8 +89,8 @@ export const WorkspaceScheduleForm: React.FC<WorkspaceScheduleFormProps> = ({ on
friday: true,
saturday: false,

startTime: "",
ttl: 0,
startTime: "09:30",
ttl: 120,
},
onSubmit,
validationSchema,
Expand All @@ -110,7 +111,7 @@ export const WorkspaceScheduleForm: React.FC<WorkspaceScheduleFormProps> = ({ on
variant="standard"
/>

<FormControl component="fieldset">
<FormControl component="fieldset" error={Boolean(form.errors.monday)}>
<FormLabel className={styles.daysOfWeekLabel} component="legend">
{Language.daysOfWeekLabel}
</FormLabel>
Expand Down Expand Up @@ -194,6 +195,7 @@ export const WorkspaceScheduleForm: React.FC<WorkspaceScheduleFormProps> = ({ on
label={Language.daySaturdayLabel}
/>
</FormGroup>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: I can create a map for these as a refactor...will do in follow-up/later.

{form.errors.monday && <FormHelperText>{Language.errorNoDayOfWeek}</FormHelperText>}
</FormControl>

<TextField
Expand Down