refactor: Minor design adjustments #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
May 20, 2022
| @@ -42,6 +42,7 @@ const useFooterStyles = makeStyles((theme) => ({ | |||
| flex: "0", | |||
| paddingTop: theme.spacing(2), | |||
| paddingBottom: theme.spacing(2), | |||
| marginTop: theme.spacing(3), | |||
There was a problem hiding this comment.
The footer was very close to the content. Added some space.
BrunoQuaresma
commented
May 20, 2022
| "& td": { | ||
| paddingTop: 16, | ||
| paddingBottom: 16, | ||
| }, |
There was a problem hiding this comment.
Other tables were using that "manually" so I extracted them to be the standard.
BrunoQuaresma
commented
May 20, 2022
| @@ -48,6 +48,7 @@ export const WorkspaceBuildPage: React.FC = () => { | |||
|
|
|||
| const useStyles = makeStyles((theme) => ({ | |||
| title: { | |||
| marginTop: theme.spacing(5), | |||
| paddingTop: theme.spacing(5), | |||
| paddingBottom: theme.spacing(2), | |||
There was a problem hiding this comment.
Add more spacing to the bottom of the Logs title.
presleyp
approved these changes
May 20, 2022
Kira-Pilot
approved these changes
May 20, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.