Skip to content

docs: comment out optional lines in values.yaml #16457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Feb 5, 2025

@michaelvp411 pointed out that some optional lines in values.yaml could lead to errors if the user doesn't opt to use them. This PR comments out those lines so that they're opt-in

preview (once cache catches up)

@EdwardAngert EdwardAngert self-assigned this Feb 5, 2025
@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Feb 5, 2025
@EdwardAngert EdwardAngert changed the title docs(fix): comment out optional lines in values.yaml docs: comment out optional lines in values.yaml Feb 5, 2025
@matifali
Copy link
Member

matifali commented Feb 6, 2025

LGTM

@EdwardAngert EdwardAngert merged commit 44d9f5f into main Feb 6, 2025
36 checks passed
@EdwardAngert EdwardAngert deleted the k8s-values-comment-opt branch February 6, 2025 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants