Skip to content

feat(cli): add display of open ports in coder show #16464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 5, 2025

Relates to #16418 -- devcontainers will be shown in a similar manner.

Without ports (status quo):
Screenshot 2025-02-10 at 12 50 46

With ports:
Screenshot 2025-02-10 at 12 50 06

@johnstcn johnstcn force-pushed the cj/agent-containers-list branch from 2c87b7e to 8b081ac Compare February 10, 2025 11:06
Base automatically changed from cj/agent-containers-list to main February 10, 2025 11:29
@johnstcn johnstcn changed the title feat(cli): display open ports in coder show feat(cli): add display of open ports in coder show Feb 10, 2025
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

var wg sync.WaitGroup
var mu sync.Mutex
for _, res := range resources {
for _, agent := range res.Agents {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not used to seeing async for loops without temp variables, scary 😆

@johnstcn johnstcn merged commit 695d552 into main Feb 10, 2025
32 checks passed
@johnstcn johnstcn deleted the cj/cli-show-ports branch February 10, 2025 13:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants