Skip to content

fix: fix broken troubleshooting link #16469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: fix broken troubleshooting link #16469

merged 1 commit into from
Feb 6, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 6, 2025

Fixes: #16468

The troubleshooting link was not updated after moving around docs.

@mtojek mtojek self-assigned this Feb 6, 2025
@mtojek mtojek changed the title fix: broken troubleshooting link fix: fix broken troubleshooting link Feb 6, 2025
@mtojek mtojek marked this pull request as ready for review February 6, 2025 07:51
@mtojek mtojek requested a review from dannykopping February 6, 2025 07:51
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ damn you're quick!

I think this is a more widespread issue, and probably something we should add a linter for somehow.

Looks like the same issue at

sw.Log(time.Now(), codersdk.LogLevelWarn, troubleshootingMessage(agent, fmt.Sprintf("%s/templates#agent-connection-issues", opts.DocsURL)))
for example.

@mtojek
Copy link
Member Author

mtojek commented Feb 6, 2025

The linter idea is intriguing, I will think about it!

Looks like the same issue at

I believe you need to refresh your fork as it seems to be fixed already.

@mtojek mtojek enabled auto-merge (squash) February 6, 2025 08:01
@mtojek mtojek merged commit 5fbedc7 into main Feb 6, 2025
36 checks passed
@mtojek mtojek deleted the 16468-link branch February 6, 2025 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
@matifali
Copy link
Member

matifali commented Feb 6, 2025

/cherry-pick release/2.19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Troubleshooting link in coder ping 404s
3 participants