Skip to content

feat: show warning on unrecognized idp group and role mapping claims #16485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 7, 2025
Merged

feat: show warning on unrecognized idp group and role mapping claims #16485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
5c09338
hoot
aslilac Feb 5, 2025
c52982e
feat: show warning on unrecognized idp org mapping claims
aslilac Feb 6, 2025
5634be1
Merge branch 'main' into lilac/idp-sync-missing-given-warning
aslilac Feb 6, 2025
63ca763
🧹
aslilac Feb 6, 2025
e55e0a8
add warning description
aslilac Feb 6, 2025
72a7986
toolptipp
aslilac Feb 6, 2025
eedf797
tweak text colors
aslilac Feb 6, 2025
06ba32d
Update site/src/pages/DeploymentSettingsPage/IdpOrgSyncPage/IdpOrgSyn…
aslilac Feb 6, 2025
9600624
this is something
aslilac Feb 6, 2025
6ffcc94
- `toString()`
aslilac Feb 6, 2025
506cca1
polish
aslilac Feb 6, 2025
c91cd1a
🧼
aslilac Feb 6, 2025
97de7f4
rename
aslilac Feb 6, 2025
06715fa
sad moment
aslilac Feb 6, 2025
42ceb1b
cntnd.
aslilac Feb 6, 2025
820cca3
huh
aslilac Feb 6, 2025
da68f4b
Merge branch 'lilac/idp-sync-missing-given-warning' into lilac/group-…
aslilac Feb 6, 2025
7a1bee3
Merge branch 'main' into lilac/group-role-sync-missing-given-warning
aslilac Feb 6, 2025
b955e4b
yet again
aslilac Feb 6, 2025
d3873ab
group tooltip thing too
aslilac Feb 7, 2025
a743cea
🧹
aslilac Feb 7, 2025
5948a61
who did this, you must be held ACCOUNTABLE (it was me)
aslilac Feb 7, 2025
ce46b06
thank you typescript I love you typescript
aslilac Feb 7, 2025
a76a243
fix tooltip positioning
aslilac Feb 7, 2025
e9a5bff
one last bit of polish
aslilac Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
toolptipp
  • Loading branch information
@aslilac
aslilac committed Feb 6, 2025
commit 72a7986188cd139a9bc1c916c30f5c2fa92c27ab
16 changes: 6 additions & 10 deletions site/src/components/Tooltip/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,12 @@ const meta: Meta<typeof TooltipProvider> = {
component: TooltipProvider,
args: {
children: (
<>
<TooltipProvider>
<Tooltip open>
<TooltipTrigger asChild>
<Button variant="outline">Hover</Button>
</TooltipTrigger>
<TooltipContent>Add to library</TooltipContent>
</Tooltip>
</TooltipProvider>
</>
<Tooltip open>
<TooltipTrigger asChild>
<Button variant="outline">Hover</Button>
</TooltipTrigger>
<TooltipContent>Add to library</TooltipContent>
</Tooltip>
),
},
};
Expand Down
31 changes: 17 additions & 14 deletions site/src/pages/DeploymentSettingsPage/IdpOrgSyncPage/IdpOrgSyncPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ import {
type Option,
} from "components/MultiSelectCombobox/MultiSelectCombobox";
import {
Popover,
PopoverContent,
PopoverTrigger,
} from "components/Popover/Popover";
Tooltip,
TooltipContent,
TooltipTrigger,
} from "components/Tooltip/Tooltip";
import { Spinner } from "components/Spinner/Spinner";
import { Switch } from "components/Switch/Switch";
import {
Expand All @@ -50,6 +50,7 @@ import { isUUID } from "utils/uuid";
import * as Yup from "yup";
import { OrganizationPills } from "./OrganizationPills";
import { Stack } from "components/Stack/Stack";
import { TooltipProvider } from "@radix-ui/react-tooltip";

interface IdpSyncPageViewProps {
organizationSyncSettings: OrganizationSyncSettings | undefined;
Expand Down Expand Up @@ -416,16 +417,18 @@ const OrganizationRow: FC<OrganizationRowProps> = ({
<Stack direction="row" alignItems="center" spacing={1}>
{idpOrg}
{!exists && (
<Popover>
<PopoverTrigger asChild>
<TriangleAlert className="size-icon-sm cursor-pointer text-content-warning" />
</PopoverTrigger>
<PopoverContent className="p-2 text-xs text-content-secondary">
This value has not be seen in the specified claim field before.
You might want to check your IdP configuration and ensure that
this value is not misspelled.
</PopoverContent>
</Popover>
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<TriangleAlert className="size-icon-sm cursor-pointer text-content-warning" />
</TooltipTrigger>
<TooltipContent className="p-2 text-xs text-content-secondary max-w-sm">
This value has not be seen in the specified claim field
before. You might want to check your IdP configuration and
ensure that this value is not misspelled.
</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
</Stack>
</TableCell>
Expand Down
Loading