Skip to content

feat(cli/server.go): allow the use of public OIDC clients #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat(cli/server.go): allow the use of public OIDC clients #16489

merged 1 commit into from
Feb 7, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Feb 7, 2025 •
edited
Loading

Support public OIDC clients

  • Enables support for public OIDC clients by only checking for a client ID being set. This allows for confidential and public clients to be used with Coder's OIDC authentication.
  • Also adds a public client configuration to the development OIDC setup script.

Fixes #16135

Change-Id: Iadd85d40c2faa595a0498e25d3407a1f94b5c8a8
Signed-off-by: Thomas Kosiewski tk@coder.com

@ThomasK33 Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 marked this pull request as ready for review February 7, 2025 11:52
@ThomasK33 ThomasK33 force-pushed the 02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branch from 6c7d77a to 9844582 Compare February 7, 2025 11:53
@ThomasK33
feat(cli/server.go): allow the use of public OIDC clients
3c81344 
Change-Id: Iadd85d40c2faa595a0498e25d3407a1f94b5c8a8
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the 02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branch from 9844582 to 3c81344 Compare February 7, 2025 11:58
mafredri
mafredri approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThomasK33 ThomasK33 merged commit 6a67e2e into main Feb 7, 2025
31 checks passed
@ThomasK33 ThomasK33 deleted the 02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branch February 7, 2025 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@ThomasK33 ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support use of public OIDC clients
3 participants
@ThomasK33 @mafredri @johnstcn