Skip to content

fix: Try to fix cli portforward test flakes #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 24, 2022
Merged

fix: Try to fix cli portforward test flakes #1650

merged 6 commits into from
May 24, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 23, 2022 •
edited
Loading

This PR attempts to fix test flakes in the portforward subcommand.

  • Guard against cmd running after test exit
  • Guard against port-reuse due to parallel tests

@mafredri mafredri self-assigned this May 23, 2022
@mafredri mafredri requested review from deansheather and johnstcn May 23, 2022 11:06
@johnstcn johnstcn mentioned this pull request May 23, 2022
Closed
@mafredri mafredri force-pushed the mafredri/try-to-fix-cli-portforward-flake branch from 65a375e to 63366b5 Compare May 23, 2022 17:11
@mafredri mafredri force-pushed the mafredri/try-to-fix-cli-portforward-flake branch from 63366b5 to f0223ac Compare May 23, 2022 17:24
@mafredri mafredri force-pushed the mafredri/try-to-fix-cli-portforward-flake branch from 81c25f3 to 0259a19 Compare May 23, 2022 20:33
deansheather
deansheather approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, I knew the ports stuff could eventually flake but didn't think of just turning off parallelism

@mafredri mafredri merged commit 34b1e19 into main May 24, 2022
@mafredri mafredri deleted the mafredri/try-to-fix-cli-portforward-flake branch May 24, 2022 08:15
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@mafredri @kylecarbs
fix: Try to fix cli portforward test flakes (#1650)
9419c9a 
* fix: Try to fix cli portforward test flakes

* fix: Guard against agent exit outside test func

* fix: Improve test teardown in setupTestListener, cleanup
@mafredri mafredri mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @deansheather