chore: return template data for provisioner daemons #16514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Feb 11, 2025
mafredri
reviewed
Feb 11, 2025
mafredri
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Looking good, Bruno! It would be good to have some test coverage of this as well in coderd/provisionerdaemons_test.go.
The current test in coderd/provisionerdaemons_test.go is pretty slim though, we have better coverage in e.g. coderd/provisionerjobs_test.go. But essentially asserting that we get the template information as well.
We implicitly get OK coverage for the existing functionality via cli/provisioners_test.go, but the new template info doesn't get tested via that.
It'd be fine if the tests are added as a follow-up PR though.
|
I will do it in a follow up PR them 👍 ty |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return template data in provisioner jobs to be displayed in the provisioners page.