Skip to content

chore(site/e2e): increase timeout for waitForPort from 30s to 60s #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 11, 2025

Relates to coder/internal#356

This is just a temporary fix; we may need to remove the hardcoded ports to avoid this flake entirely.

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me – totally okay with using this as a bandaid solution

@johnstcn johnstcn merged commit 25d256e into main Feb 11, 2025
36 checks passed
@johnstcn johnstcn deleted the cj/flake/e2e-external-auth branch February 11, 2025 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants