Skip to content

fix: display error on deleted workspace build #16536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 12, 2025

Fixes: #15058

This PR modifies WorkspaceBuildPageView to display an error if the related workspace build cannot be accessed or is deleted. The error alert component is consistent with one on the workspace page.

Screenshot 2025-02-12 at 11 56 55

@mtojek mtojek self-assigned this Feb 12, 2025
@mtojek mtojek marked this pull request as ready for review February 12, 2025 11:14
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mtojek mtojek merged commit d7614a4 into main Feb 12, 2025
34 checks passed
@mtojek mtojek deleted the 15058-fix-spinner branch February 12, 2025 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard spins forever if you try to access build from a deleted workspace
2 participants