fix: display the correct response for coder list #16547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Feb 12, 2025
43ac0f0 to
2a5a34b
Compare
2a5a34b to
a12f553
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16312
We intend to modify the behavior of the CLI handler based on the specified output format. However, the output format is currently only accessible within the
OutputFormatterstructure. Therefore, I propose extendingOutputFormatterby introducing a publicFormatIDmethod, which will allow us to retrieve the format identifier and use it to customize the behavior of the CLI handler accordingly.An alternative approach would be to make the implementation more generic. Instead of defining a
FormatIDmethod, we could introduce anIsMachineReadableFormat() boolmethod. This method would indicate whether the output format is machine-readable, allowing us to adjust the CLI handler's behavior accordingly.