fix: stop text from overflowing on delete org button #16549
Merged
+7
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
reviewed
Feb 13, 2025
| <HorizontalSection | ||
| title="Settings" | ||
| description="Change or delete your organization." | ||
| > | ||
| <div css={styles.dangerSettings}> | ||
| <div className="flex bg-surface-orange items-center justify-between border border-solid border-orange-600 rounded-[8px] p-3 pl-[18px] gap-2 flex-grow"> |
There was a problem hiding this comment.
We should actually avoid setting explicit styles with Tailwind as much as possible.
For rounded-, there actually will be some work in the future to update these in the tailwind.config. If this is set to rounded-md it will automatically gets that update and therefore the consistency in the future.
For pl-[18px], it would be better to just choose one of the closest classes either pl-4 or pl-5
In general, we should only use the explicit styling if that was a decision made in the Figma designs or the utility class options are really too different from what looks correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16433
I also took the opportunity to convert the components to tailwind. Since there aren't designs for this piece of UI yet I tried to match it as closely as possible using the existing tailwind config