ok

coder · aslilac · Mar 5, 2025 · Feb 13, 2025 · Feb 13, 2025 · Feb 14, 2025
commit bb1ac6e704a24d94e448996da485b47899246930
diff --git a/coderd/users.go b/coderd/users.go
@@ -989,11 +989,15 @@ func (api *API) userAppearanceSettings(rw http.ResponseWriter, r *http.Request)
 
 	themePreference, err := api.Database.GetUserAppearanceSettings(ctx, user.ID)
 	if err != nil {
-		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
-			Message: "Internal error updating user.",
-			Detail:  err.Error(),
-		})
-		return
+		if !errors.Is(err, sql.ErrNoRows) {
+			httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
+				Message: "Error reading user settings.",
+				Detail:  err.Error(),
+			})
+			return
+		}
+
+		themePreference = ""
 	}
 
 	httpapi.Write(ctx, rw, http.StatusOK, codersdk.UserAppearanceSettings{

diff --git a/site/site.go b/site/site.go
@@ -437,6 +437,10 @@ func (h *Handler) renderHTMLWithState(r *http.Request, filePath string, state ht
 	eg.Go(func() error {
 		var err error
 		themePreference, err = h.opts.Database.GetUserAppearanceSettings(ctx, apiKey.UserID)
+		if errors.Is(err, sql.ErrNoRows) {
+			themePreference = ""
+			return nil
+		}
 		return err
 	})
 	eg.Go(func() error {

diff --git a/site/site_test.go b/site/site_test.go
@@ -65,6 +65,9 @@ func TestInjection(t *testing.T) {
 
 	handler.ServeHTTP(rw, r)
 	require.Equal(t, http.StatusOK, rw.Code)
+	fmt.Println("oh boy oh boy oh boy")
+	fmt.Println(rw.Body.String())
+	fmt.Println("oh boy oh boy oh boy")
 	var got codersdk.User
 	err := json.Unmarshal([]byte(html.UnescapeString(rw.Body.String())), &got)
 	require.NoError(t, err)