Skip to content

feat(site): add support for presets to the create workspace page #16567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 18, 2025
Merged

feat(site): add support for presets to the create workspace page #16567

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f53056
add support for presets to the coder frontend
SasSwart Feb 14, 2025
b1aff3f
Collect all todo testcases in a single file
SasSwart Feb 14, 2025
8d08a64
remove todos
SasSwart Feb 14, 2025
da9239e
add a story to test when a preset has been selected
SasSwart Feb 14, 2025
e47296c
make -B fmt
SasSwart Feb 14, 2025
ae19b51
Merge remote-tracking branch 'origin/main' into jjs/presets-fe
SasSwart Feb 17, 2025
6787f10
review notes
SasSwart Feb 18, 2025
4cc78c9
review notes
SasSwart Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove todos
  • Loading branch information
@SasSwart
SasSwart committed Feb 14, 2025
commit 8d08a644fd0d37f6d3f3a41762b0a2eaa994ee99
10 changes: 0 additions & 10 deletions coderd/presets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ import (
)

func TestTemplateVersionPresets(t *testing.T) {
// TODO (sasswart): test case: what if immutable parameters are used in the preset?
// TODO (sasswart): test case: what if presets are defined for a template version with no params?
// TODO (sasswart): test case: what if a non active version is selected?
// TODO (sasswart): test case: what if a preset is selected that has no parameters?
// TODO (sasswart): what if we have preset params and autofill params on the same param?
// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?
// If so, how should it behave? Reset to initial value? reset to last set value?
// TODO (sasswart): test case: rich parameters
// TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org?

t.Parallel()

givenPreset := codersdk.Preset{
Expand Down
Loading