Skip to content

feat(provisioner): add support for presets to coder provisioners #16574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2025

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Feb 14, 2025

This pull request adds support for presets to coder provisioners.
If a template defines presets using a compatible version of the provider, then this PR will allow those presets to be persisted to the control plane database for use in workspace creation.

@SasSwart SasSwart force-pushed the jjs/presets-provisioner branch from 0584acb to 75a5d49 Compare February 14, 2025 13:21
@SasSwart SasSwart changed the title Add support for presets to coder provisioners feat(provisioner): add support for presets to coder provisioners Feb 14, 2025
@SasSwart SasSwart marked this pull request as ready for review February 14, 2025 13:44
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I encourage you to split out the provider changes.

required_providers {
coder = {
source = "coder/coder"
version = "0.22.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was copy-pasta, but we should update all of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferring this until we have a tagged release of the provider to update it to.

@SasSwart SasSwart merged commit 46e04c6 into main Feb 17, 2025
33 checks passed
@SasSwart SasSwart deleted the jjs/presets-provisioner branch February 17, 2025 11:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants