Skip to content

fix(coderd): add stricter authorization for provisioners endpoint #16587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

fix(coderd): add stricter authorization for provisioners endpoint #16587

merged 3 commits into from
Feb 17, 2025

Conversation

mafredri
Copy link
Member

References #16558

@mafredri mafredri self-assigned this Feb 17, 2025
@mafredri mafredri requested a review from johnstcn February 17, 2025 10:00
johnstcn
johnstcn previously approved these changes Feb 17, 2025
View reviewed changes
johnstcn
johnstcn reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests are fixed.

EDIT: this might actually cause issues with user-owned provisioner daemons.

@mafredri mafredri force-pushed the mafredri/feat-coderd-provisioner-auth branch from a111e1e to 2f4f1f7 Compare February 17, 2025 11:20
@mafredri mafredri force-pushed the mafredri/feat-coderd-provisioner-auth branch from 2f4f1f7 to 360f8a6 Compare February 17, 2025 11:20
@johnstcn johnstcn dismissed their stale review February 17, 2025 11:49

user-local provisioner daemons

johnstcn
johnstcn approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified interaction with user-scoped provisioners; existing tests still pass.

@mafredri mafredri merged commit 7f061b9 into main Feb 17, 2025
30 checks passed
@mafredri mafredri deleted the mafredri/feat-coderd-provisioner-auth branch February 17, 2025 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @johnstcn