fix(flake.nix): add procps to nix dogfood image #16607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I85432acc06a204229fa3675e0020bd3acacf775a Signed-off-by: Thomas Kosiewski <tk@coder.com>
johnstcn
approved these changes
Feb 18, 2025
| @@ -50,6 +50,10 @@ let | |||
| experimental-features = nix-command flakes | |||
| ''; | |||
|
|
|||
| etcReleaseName = writeTextDir "etc/coderniximage-release" '' | |||
| 0.0.0 | |||
There was a problem hiding this comment.
nit: wonder if it would make sense to have some kind of versioning here?
There was a problem hiding this comment.
I agree. It would make sense to get some versioning here.
Right now, we're not versioning the dogfood images, so this file is mostly a stub/placeholder for the system info go library not to fail.
There was a problem hiding this comment.
I could add the output of git describe --tags here, or we could consider versioning the dogfood images, in which case the image tag should go here.
There was a problem hiding this comment.
That or git SHA would probably be fine!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add procps to flake.nix and release name to Docker image
Adds the
procpspackage to flake.nix to enable thefreecommand, and includes a release name file in the Docker image at/etc/coderniximage-release.Change-Id: I85432acc06a204229fa3675e0020bd3acacf775a
Signed-off-by: Thomas Kosiewski tk@coder.com