Skip to content

refactor: Increase navbar height #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

refactor: Increase navbar height #1662

merged 1 commit into from
May 23, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

The navbar is too tight and needs a bit more space. The usual height for navbars is 62px like GitHub does.

Before:
Screen Shot 2022-05-23 at 10 27 42

After:
Screen Shot 2022-05-23 at 10 27 36

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner May 23, 2022 13:30
@BrunoQuaresma BrunoQuaresma self-assigned this May 23, 2022
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 23, 2022 13:30
@BrunoQuaresma BrunoQuaresma merged commit 1f03277 into main May 23, 2022
presleyp
presleyp approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@BrunoQuaresma BrunoQuaresma deleted the bq/update-navbar-spacing branch May 23, 2022 14:22
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
refactor: Increase navbar height (#1662)
b456765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @presleyp