Skip to content

fix: center proxy spinner #16621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: center proxy spinner #16621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions site/src/components/Latency/Latency.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,14 @@ import { getLatencyColor } from "utils/latency";
interface LatencyProps {
latency?: number;
isLoading?: boolean;
size?: number;
}

export const Latency: FC<LatencyProps> = ({ latency, isLoading }) => {
export const Latency: FC<LatencyProps> = ({
latency,
isLoading,
size = 14,
}) => {
const theme = useTheme();
// Always use the no latency color for loading.
const color = getLatencyColor(theme, isLoading ? undefined : latency);
Expand All @@ -21,7 +26,7 @@ export const Latency: FC<LatencyProps> = ({ latency, isLoading }) => {
return (
<Tooltip title="Loading latency...">
<CircularProgress
size={14}
size={size}
css={{ marginLeft: "auto" }}
style={{ color }}
/>
Expand Down
1 change: 1 addition & 0 deletions site/src/modules/dashboard/Navbar/ProxyMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export const ProxyMenu: FC<ProxyMenuProps> = ({ proxyContextValue }) => {
<Latency
latency={latencies?.[selectedProxy.id]?.latencyMS}
isLoading={proxyLatencyLoading(selectedProxy)}
size={24}
/>
</div>
) : (
Expand Down
Loading