Skip to content

fix: show an error banner if the user does not have permission to view the audit page #16637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix: show an error banner if the user does not have permission to view the audit page #16637

merged 2 commits into from
Feb 20, 2025

Conversation

brettkolodny
Copy link
Contributor

No description provided.

aslilac
aslilac approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting choice to do the auth check in a middleware rather than the route, but it works! ✨

@brettkolodny brettkolodny merged commit 54b09d9 into main Feb 20, 2025
35 checks passed
@brettkolodny brettkolodny deleted the brett/bug-unpermissioned-users-see-empty-audit-route-342 branch February 20, 2025 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@brettkolodny brettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettkolodny @aslilac