Skip to content

refactor: Move schedule info to the sidebar #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented May 23, 2022

Screen Shot 2022-05-23 at 11 20 35

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner May 23, 2022 14:22
@BrunoQuaresma BrunoQuaresma self-assigned this May 23, 2022
@BrunoQuaresma
Copy link
Collaborator Author

cc.: @vapurrmaid

@ammario
Copy link
Member

ammario commented May 23, 2022

I agree with the need to cleanly separate the schedule from the status bar. The new column looks odd to me, because I think that every item in a column would follow some consistent theme. I can't think of other items to put in that column that would relate to auto start, though.

@BrunoQuaresma
Copy link
Collaborator Author

@ammario yes, I agree. I could not think of a better place to put the schedule info tho. Also, I think the sidebar can be a good place to add more "info" in the future if we need it like this:

Screen Shot 2022-05-23 at 11 32 56

@ammario
Copy link
Member

ammario commented May 23, 2022

Gotcha @BrunoQuaresma. It seems fine to me. Why did you remove the background format from the panels? I think the consistency between the panel and Timeline styles looked good.

@BrunoQuaresma
Copy link
Collaborator Author

@ammario it is just an old screenshot from a Figma file that I haven't updated yet.

@BrunoQuaresma BrunoQuaresma merged commit 9f3a6d6 into main May 23, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-workspace-sidebar branch May 23, 2022 14:41
@ammario
Copy link
Member

ammario commented May 23, 2022

Sorry, I meant the Schedule panel as well. I think it should have a background for consistency.
image

@BrunoQuaresma
Copy link
Collaborator Author

I see, I think adding a background to it will make the design looks very blocked, but I will play around with this idea. I've been using the GitHub sidebar as a reference.

Screen Shot 2022-05-23 at 13 51 53

@ammario
Copy link
Member

ammario commented May 23, 2022

GitHub is an interesting case study. I think the horizontal separators can do a lot for the design.

@misskniss
Copy link

fixes #1661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants