fix: omit login redirect param #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #1282
|
Don't worry about it, some router stuff is just too hard to test expect in an E2E test. We have an E2E ticket for testing redirects so you could just make sure this use case is listed there for testing. Is the util function you're using unit tested? |
BrunoQuaresma
approved these changes
May 23, 2022
presleyp
approved these changes
May 23, 2022
@presleyp yes it is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1282
I spent a fair amount of time attempting to write a test for this, but couldn't mock out the router in such a way that the redirect param
?redirect=%2Freared its ugly head. Tried: using the test helpers and wrappers inrenderHelpers.tsx, mocking logged out state similarly toLoginPage.test.tsx, and even mocking outauthState. Any ideas welcome.