feat: show dialog with a redirect if permissions are required #16661
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Feb 21, 2025
| @@ -14,7 +22,25 @@ export const RequirePermission: FC<RequirePermissionProps> = ({ | |||
| isFeatureVisible, | |||
| }) => { | |||
| if (!isFeatureVisible) { | |||
| return <Navigate to="/workspaces" />; | |||
| // return <Navigate to="/workspaces" />; | |||
There was a problem hiding this comment.
Suggested change
| // return <Navigate to="/workspaces" />; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes this issue
New behavior
When a user ends up on a page they don't have permission to view instead of being redirected back to /workspaces they'll be met with the un-closeable dialog below with a link to /workspaces.
This is similar to this PR but IMO we should be making sure we are using
<RequirePermissions />wherever applicable and only relying on<ErrorAlert />as a fallback in case there is some page we missed or endpoint we're accidentally using.