-
Notifications
You must be signed in to change notification settings - Fork 875
docs: document default GitHub OAuth2 configuration and device flow #16663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da04e13
to
1bd4a54
Compare
2788eb5
to
eb41f65
Compare
59d6043
to
fb471f9
Compare
032150d
to
9a15225
Compare
9a15225
to
407cdd3
Compare
fb471f9
to
da869e0
Compare
Let's wait before merging this: I'm actually not sure if Coder the company gets the accesses I outlined. I'll double check and confirm by Friday. |
da869e0
to
b7ea9ae
Compare
071d6cc
to
1720441
Compare
d8a0541
to
34d6000
Compare
1720441
to
297e90b
Compare
b060a1e
to
0ade9a2
Compare
@EdwardAngert I checked and I believe the company doesn't get access to the data after all. I added the "to the best of our knowledge" disclaimer because GitHub documentation doesn't directly say an app's administrator doesn't get access. I looked and as far as I can tell, it doesn't specify a way to get this data, and I wasn't able to obtain it in my testing. I can't point to a specific piece of documentation that says it can't be done, so there might be a way I'm not aware of. GitHub only lets the app administrator see users who use its app if the user installs it in their account, but in the login process the Coder server authenticates with the GitHub app on behalf of the user instead. Let me know if the copy looks good to you. |
0ade9a2
to
f77b54b
Compare
f77b54b
to
ebd0a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release/2.20 |
Document the changes made in #16629 and #16585.