Skip to content

docs: document default GitHub OAuth2 configuration and device flow #16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

hugodutka
Copy link
Contributor

Document the changes made in #16629 and #16585.

@hugodutka hugodutka changed the title docs: default GitHub OAuth2 configuration and device flow docs: document default GitHub OAuth2 configuration and device flow Feb 22, 2025
@hugodutka hugodutka marked this pull request as ready for review February 23, 2025 18:06
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch 2 times, most recently from da04e13 to 1bd4a54 Compare February 24, 2025 13:55
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-default branch from 2788eb5 to eb41f65 Compare February 24, 2025 16:19
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch 3 times, most recently from 59d6043 to fb471f9 Compare February 24, 2025 16:59
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-default branch from 032150d to 9a15225 Compare February 24, 2025 16:59
@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Feb 24, 2025
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-default branch from 9a15225 to 407cdd3 Compare February 24, 2025 18:03
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch from fb471f9 to da869e0 Compare February 24, 2025 18:03
@hugodutka
Copy link
Contributor Author

Let's wait before merging this: I'm actually not sure if Coder the company gets the accesses I outlined. I'll double check and confirm by Friday.

@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch from da869e0 to b7ea9ae Compare February 24, 2025 20:37
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-default branch 2 times, most recently from 071d6cc to 1720441 Compare February 24, 2025 20:57
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch 2 times, most recently from d8a0541 to 34d6000 Compare February 25, 2025 15:16
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-default branch from 1720441 to 297e90b Compare February 25, 2025 15:16
Base automatically changed from hugodutka/github-oauth2-default to main February 25, 2025 15:31
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch 3 times, most recently from b060a1e to 0ade9a2 Compare February 28, 2025 17:22
@hugodutka
Copy link
Contributor Author

hugodutka commented Feb 28, 2025

@EdwardAngert I checked and I believe the company doesn't get access to the data after all. I added the "to the best of our knowledge" disclaimer because GitHub documentation doesn't directly say an app's administrator doesn't get access. I looked and as far as I can tell, it doesn't specify a way to get this data, and I wasn't able to obtain it in my testing. I can't point to a specific piece of documentation that says it can't be done, so there might be a way I'm not aware of.

GitHub only lets the app administrator see users who use its app if the user installs it in their account, but in the login process the Coder server authenticates with the GitHub app on behalf of the user instead.

Let me know if the copy looks good to you.

@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch from 0ade9a2 to f77b54b Compare February 28, 2025 17:31
@hugodutka hugodutka force-pushed the hugodutka/github-oauth2-docs branch from f77b54b to ebd0a93 Compare February 28, 2025 17:52
@hugodutka hugodutka requested a review from matifali February 28, 2025 17:58
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugodutka hugodutka merged commit a5842e5 into main Mar 3, 2025
28 checks passed
@hugodutka hugodutka deleted the hugodutka/github-oauth2-docs branch March 3, 2025 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@stirby
Copy link
Collaborator

stirby commented Mar 3, 2025

/cherry-pick release/2.20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants