Skip to content

chore: show server install.sh on cli version mismatch #16668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

chore: show server install.sh on cli version mismatch #16668

merged 3 commits into from
Feb 25, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Feb 24, 2025 •
edited
Loading

This PR has the CLI show the server's own install.sh script if there's a version mismatch, and if the deployment doesn't have an custom upgrade message configured.

$ coder ls
version mismatch: client {version}, server {version}
download {server_version} with: 'curl -fsSL https://dev.coder.com/install.sh | sh'
[ ... ]

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review February 24, 2025 06:16
aslilac
aslilac approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion about the wording of the message, but looks good!

@ethanndickson ethanndickson force-pushed the ethan/show-server-install-cli branch from 33de05d to 5b499d2 Compare February 25, 2025 02:21
@ethanndickson ethanndickson enabled auto-merge (squash) February 25, 2025 02:22
@ethanndickson ethanndickson merged commit 6bdddd5 into main Feb 25, 2025
31 checks passed
@ethanndickson ethanndickson deleted the ethan/show-server-install-cli branch February 25, 2025 02:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @aslilac