fix(coderd): handle deletes and links for new agent/app audit resources #16670
Conversation
| if xerrors.Is(err, sql.ErrNoRows) { | ||
| return true | ||
| } | ||
| api.Logger.Error(ctx, "unable to fetch workspace", slog.Error(err)) |
There was a problem hiding this comment.
Review: This code-path is confusing, I feel we should return an explicit boolean here, but I simply followed existing convention.
There was a problem hiding this comment.
I agree. Do we run a db query for every single audit log row? I was unaware this function existed tbh
There was a problem hiding this comment.
Yeah, sure looks like we call it as part of convertAuditLog 😰. I'm surprised the API response isn't slower TBH.
There was a problem hiding this comment.
I created an issue: #16718
| if xerrors.Is(err, sql.ErrNoRows) { | ||
| return true | ||
| } | ||
| api.Logger.Error(ctx, "unable to fetch workspace", slog.Error(err)) |
There was a problem hiding this comment.
I agree. Do we run a db query for every single audit log row? I was unaware this function existed tbh
Yeah, I was pretty surprised as well. I'm going to merge this but let's create a follow-up issue to track improvements to this code-path. |
These code-paths were overlooked in #16493.