Skip to content

feat: cli configs should not be space sensitive #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022
Merged

feat: cli configs should not be space sensitive #1668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: cli configs should not be space sensitive 
If you edit the file and add a newline, it breaks. It should not matter
  • Loading branch information
@Emyrk
Emyrk committed May 23, 2022
commit 63579ca64aee3543bbe7b6fd392d37ada5c261b3
5 changes: 3 additions & 2 deletions cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"net/url"
"os"
"strings"
"time"

"github.com/kirsle/configdir"
Expand Down Expand Up @@ -115,7 +116,7 @@ func createClient(cmd *cobra.Command) (*codersdk.Client, error) {
return nil, err
}
}
serverURL, err := url.Parse(rawURL)
serverURL, err := url.Parse(strings.TrimSpace(rawURL))
if err != nil {
return nil, err
}
Expand All @@ -127,7 +128,7 @@ func createClient(cmd *cobra.Command) (*codersdk.Client, error) {
}
}
client := codersdk.New(serverURL)
client.SessionToken = token
client.SessionToken = strings.TrimSpace(token)
return client, nil
}

Expand Down