Skip to content

fix: display banner when no matching templates found #16696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 25, 2025

Fixes: #16077

This PR modifies the TemplatePage view to indicate that all template have been filtered out rather than asking to create a new template. It is consistent with WorkspacesPage view.

Screenshot 2025-02-25 at 14 22 26

@mtojek mtojek self-assigned this Feb 25, 2025
@mtojek mtojek changed the title fix: no templates match criteria fix: display: no templates match criteria Feb 25, 2025
@mtojek mtojek changed the title fix: display: no templates match criteria fix: display banner when no matching templates found Feb 25, 2025
@mtojek mtojek marked this pull request as ready for review February 25, 2025 13:27
@mtojek mtojek requested review from johnstcn and mafredri February 25, 2025 13:27
@mtojek mtojek merged commit b419b36 into main Feb 25, 2025
38 of 40 checks passed
@mtojek mtojek deleted the 16077-criteria branch February 25, 2025 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't show "create your first template" when no templates match search criteria
2 participants